[DRAFT] Mark fragments with empty appends with gap #6218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
mp4 segments missing IDR frames at the start will result in nothing added to the buffer after first append.
Frag parsing error events resolve with a level switch which can result in an alternative to media missing an IDR.
HLS mp4 segments should always start with an IDR frame (ISO BMFF) so warning when that is not the case and it is expected to result in gaps (non-contiguous append) will help to identify bad HLS assets.
Are there any points in the code the reviewer needs to double check?
Backtracking was tuned to work with the TS pipeline (primarily muxed content). It won't always find the ideal candidate. Erroring helps if there are alternatives, but if there are none HLS.js may still end up loop loading around gaps.
Relates to:
Resolves issues:
Checklist