-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install via NPM in Angular application #8141
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
I know a fix is in code review, and I super appreciate the video.js team's very fast response time to this. |
@LexanRed This issue was resolved by adding the below option to tsconfig.json file. "skipLibCheck": true, |
@ashwiniLiman thanks for the note. Very helpful to know. For the video.js team: I just installed version 8.2.0 which includes #8148 If we need to change our imports, would be great if there could be a guide. In any case, thanks again for your library. |
+1 |
1 similar comment
+1 |
I keep getting error in Angular 15 |
Hello again.
So it never gets to Please upon please fix the issues building everything and this might fix angular 15 not installing. Please see this: I then made the following fix locally: Replace this: Then replace this: I might make a PR soon if I can. Thanks!! |
I keep getting error in Angular 14 |
After rolling back video.js to version 7.21.2, the problem was resolved |
@Charlie50503 thanks for the workaround. |
+1 |
This problem still persists in 8.3.0 |
+1 |
+1 Same issues with 8.4.1 |
+1 |
1 similar comment
+1 |
I am not sure why you folks keep spamming the +1. Obviously it is not fixed. Maybe we can start spending some time debugging the issue and providing a fix? Give and be given. Maybe this attempt of fixing the issue is a good starting point: #8217 |
@lksnmnn thanks for your comment. As you can see above, the first thing I did was try to build it locally. We have video.js 7 in our angular application. In video.js 7 they seemed to use the types/video.js npm library for types and now it seems to be inside this module. |
I opened a PR that fixes all issues in 8.5.0. |
Any movement on this, just tried to upgrade to video.js version 8.3 and seeing the same above mentioned errors with an Angular 15 app. |
is this planning to be merged, I would love to upgrade my videojs to 8.5 inside an angular 15 project. |
After updating to 8.6.1 which includes the PR fix from @mattcwebster, I get an additional errors following the same convention as the Angular guide. https://videojs.com/guides/angular/ error TS2724: 'videojs' has no exported member named 'Player'. Did you mean 'players'? |
@psiservices-ben-voytko I use |
@boris-petrov Thanks, that seems to work. Just looks like the guide needs to be updated. |
This is not working for me. |
I haven't gone through our application extensively to upgrade. There are a large number of types under video.js/dist/types and they're well organized.
Also seems like creating a modal has totally changed. Just wanted to thank all the contributors to this project. Small note: would be great if the migration guide had more for those of us using angular: |
Just wanted to add that this morning I successfully ran videojs version 8.9.0 with angular. I found 3 more issues compiling and wanted to post some of the fixes we did. player.controlBar doesn't exist any more.
We had a JS error in our code for a custom button in the toolbar.
Also for modal dialogs: if you add a modal dialog as a child, you need to caste it to a component.
|
Description
When installing vidoe.js via NPM and trying to include it in an Angular 15 application I get all kind of strange errors.
I assume the guide on https://videojs.com/guides/angular/ is outdated.
Also when trying to import the player like this: import Player from "video.js/dist/types/player";
The errors persist.
I also tried installing the video.js types. Unfortunately there are no types for v8 yet.
In anyway, it is not possible to install it via NPM into an Angular 15 application.
Reduced test case
No response
Steps to reproduce
Errors
No response
What version of Video.js are you using?
8.0.4
Video.js plugins used.
None
What browser(s) including version(s) does this occur with?
What OS(es) and version(s) does this occur with?
The text was updated successfully, but these errors were encountered: