-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 8141: fix npm run build sass icon failure which prevents types from being built #8217
base: main
Are you sure you want to change the base?
Fix 8141: fix npm run build sass icon failure which prevents types from being built #8217
Conversation
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #8217 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 112 112
Lines 7402 7402
Branches 1785 1785
=======================================
Hits 6078 6078
Misses 1324 1324 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is there any update on this one? |
Alas I have reason to believe that this PR won't fix the issue. |
Hey @zorent-zebra thanks for the PR! I've converted this to a draft based on the last comment. Feel free to update when you can and mark it ready for review. |
Description
Attempt to fix angular not building in video.js version 8 reported in #8141
Specific Changes proposed
sass was erroring out for me when running
npm run build
on the stepsbuild:css:cdn
andbuild:css:default
.This seemed to cause the build not to get to
build:types
.In my local 8.2.1 video.js in angular, there is no file
./dist/types/video.d.ts
.My guess is that it's due to this build failure.
I haven't checked whether this affects building using yarn....
We don't use yarn.
Requirements Checklist