-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display time tooltip for mobile when sliding #7598
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7598 +/- ##
==========================================
- Coverage 80.24% 80.24% -0.01%
==========================================
Files 116 116
Lines 7325 7324 -1
Branches 1771 1770 -1
==========================================
- Hits 5878 5877 -1
Misses 1447 1447 ☔ View full report in Codecov by Sentry. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
The current behaviour to hide was added in #4185, in 2017. On a modern Android Chrome the tooltips look fine with this PR, but I'm not sure what problems needed to be avoided back then. |
It was turned off because the tooltips definitely weren't working right back then on touch (mobile) devices. |
Do you remember with what OS/device? I could try to test this PR on them using browser stack |
Unfortunately, I do not remember. I'm also not sure that testing via browserstack would be reliable enough here. |
Any updates on this? |
Hi :)
Description
Display time tooltip when sliding on mobile. Without this, it's difficult to move to the desired timestamp on android/ios.
Specific Changes proposed
Enable
timeTooltip
for mobile and adapt CSS to always display it when sliding.Requirements Checklist