Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new integration panda-css #421

Merged
merged 14 commits into from
Nov 20, 2024
Merged

feat: new integration panda-css #421

merged 14 commits into from
Nov 20, 2024

Conversation

phonzammi
Copy link
Member

@phonzammi phonzammi commented Nov 9, 2024

TODO:

  • Usage with React, SolidJS & Vue
  • E2E Test

@phonzammi phonzammi marked this pull request as ready for review November 13, 2024 12:40
@phonzammi
Copy link
Member Author

@magne4000, This PR is ready for reviews, please take a look.
Please help me fix the remaining ci errors :

 Running knip
 Remote caching enabled
knip
cache miss, executing ce05395cfb8e7ba1
$ VITE_CJS_IGNORE_WARNING=1 knip
Unused files (1)
panda.config.ts
Unused devDependencies (1)
postcss  package.json
Configuration hints (5)
Unused item in ignoreDependencies: @batijs/tests-utils
Unused item in ignoreDependencies: happy-dom
Unused item in ignoreDependencies: eslint
Unused item in ignoreDependencies: react-dom
Unused item in ignoreDependencies: @types/react-dom
error: script "knip" exited with code 1
Error:  command finished with error: command (/home/runner/work/bati/bati/react--panda-css--eslint/) /home/runner/.bun/bin/bun run knip exited (1)
Error: knip: command (/home/runner/work/bati/bati/react--panda-css--eslint/) /home/runner/.bun/bin/bun run knip exited (1)

@magne4000
Copy link
Member

@phonzammi To fix the knip errors, you need to update createKnipConfig

Probably something like this:

if (flags.includes("panda-css")) {
  entry.push("panda.config.ts");
  ignoreDependencies.push("postcss");
}

@magne4000
Copy link
Member

FYI I plan to split createKnipConfig into their respective boilerplate folder, but I still need to decide how I should to that.

@phonzammi
Copy link
Member Author

To fix the knip errors, you need to update createKnipConfig

Thanks, it works 👍

boilerplates/react/panda.config.ts Outdated Show resolved Hide resolved
boilerplates/solid/panda.config.ts Outdated Show resolved Hide resolved
boilerplates/vue/panda.config.ts Outdated Show resolved Hide resolved
@magne4000 magne4000 merged commit ff3cfbd into vikejs:main Nov 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants