Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nikic/php-parser version 5+ #11112

Open
michnovka opened this issue Oct 7, 2024 · 3 comments
Open

Add support for nikic/php-parser version 5+ #11112

michnovka opened this issue Oct 7, 2024 · 3 comments

Comments

@michnovka
Copy link
Contributor

Because of psalm depending on nikic/php-parser ^4.17.0, I cannot use phpunit 11, as that requires "phpunit/php-code-coverage": "^11.0.6" which in turn requires "nikic/php-parser": "^5.1.0"

The conflict I have is clear here:

$ composer why nikic/php-parser
phpunit/php-code-coverage 9.2.32  requires  nikic/php-parser (^4.19.1 || ^5.1.0) 
sebastian/complexity      2.0.3   requires  nikic/php-parser (^4.18 || ^5.0)     
sebastian/lines-of-code   1.0.4   requires  nikic/php-parser (^4.18 || ^5.0)     
symfony/maker-bundle      v1.61.0 requires  nikic/php-parser (^4.18|^5.0)        
vimeo/psalm               5.26.1  requires  nikic/php-parser (^4.17)             
vimeo/psalm               5.26.1  conflicts nikic/php-parser (4.17.0) 
Copy link

Hey @michnovka, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

@michnovka
Copy link
Contributor Author

This issue does not apply to psalm syntax check, but rather dependencies

@kochen
Copy link

kochen commented Oct 8, 2024

@michnovka work has started here: #11035

damiendart added a commit to damiendart/kew that referenced this issue Nov 12, 2024
Update PHP dependencies and change the Psalm dependency to use the
self-contained PHP archive version to fix dependency conflicts (for more
information, see <vimeo/psalm#11112>).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants