Support to load extraFiles from PHAR

[filips123]

I have installed PHPUnit (and other dev-related tools, including Psalm) as PHAR using Phive to vendor/bin/phpunit. PHPUnit is not required as dev dependency in composer.json, so its classes won't load using autoloader, but will still be available when you run PHPUnit because PHAR will provide them. This will cause Psalm to think classes such as PHPUnit\Framework\TestCase do not exist and fail to analyze.

I tried to provide path to PHAR (vendor/bin/phpunit) in extraFiles option in config, both as file and directory, but this doesn't fix the problem. If I provide path as file, Psalm will load but continue to fail to recognise classes. If I provide path as directory, Psalm will fail to load and say that is not a directory.

Is it possible to provide support for loading extraFiles from PHARs? It would be very useful if you don't want to add too many dev tool dependencies to your project, causing slow installation time and possible dependency conflicts.

[psalm-github-bot]

Hey @filips123, can you reproduce the issue on https://psalm.dev ?

[xPaw]

This would indeed be nice. I'm also using it like this:

require __DIR__ . '/bugsnag.phar';
$bugsnag = \Bugsnag\Client::make( Config::$BugsnagKey, \Bugsnag\Client::ENDPOINT );

ERROR: MissingFile - bugsnag.phar:4:1 - Cannot find file phar:\bugsnag.phar\autoloader.php to include (see https://psalm.dev/107)
ERROR: UndefinedClass - Class or interface Bugsnag\Client does not exist (see https://psalm.dev/019)

[ro0NL]

Here's how i managed to do it

<extraFiles>
    <directory name="var/phpunit"/>
</extraFiles>

wget -O bin/phpunit.phar https://phar.phpunit.de/phpunit-9.phar && \
chmod +x bin/phpunit.phar && \
php -r "(new Phar('bin/phpunit.phar'))->extractTo('var/phpunit', null, true);"

Then in CI where phpunit is already available you could create a symlink instead.