-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducible builds (fixes #10446) #10566
Open
danog
wants to merge
10
commits into
vimeo:master
Choose a base branch
from
danog:add_composer_lock
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danog
added
the
release:internal
The PR will be included in 'Internal changes' section of the release notes
label
Jan 17, 2024
danog
changed the title
Add composer.lock to phar (fixes #10446)
Reproducible builds (fixes #10446)
Jan 17, 2024
drupol
reviewed
Jan 17, 2024
@@ -2,11 +2,14 @@ | |||
"minimum-stability": "dev", | |||
"prefer-stable": true, | |||
"require": { | |||
"humbug/box": "^3.16.0" | |||
"humbug/box": "^4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would require ^4.6
here.
drupol
reviewed
Jan 17, 2024
Hi, What's missing in this PR? I really wish we could move forward with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.