Fix double-keystroke bug in layout selection #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a bug when selecting a layout where you need to press keys 2-3 times for them to register. I have no idea why, but this fixes it. Something about starting a Tui instance to select the workspace, closing it, and then starting another one to select the layout doesn't work. This change starts a Tui instance as needed earlier in the program and passes it around until we're done using it. Also slightly refactors a couple places.
vinnymeller
force-pushed
the
fix-double-tab-bug-in-layout-selection
branch
from
bd08544 to
004acee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug when selecting a layout where you need to press keys 2-3 times for them to register. I have no idea why, but this fixes it.
Something about starting a Tui instance to select the workspace, closing it, and then starting another one to select the layout doesn't work.
This change starts a Tui instance as needed earlier in the program and passes it around until we're done using it.