Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rework vat #46

Merged
merged 13 commits into from
Dec 6, 2024
Merged

feat: Rework vat #46

merged 13 commits into from
Dec 6, 2024

Conversation

sveneberth
Copy link
Member

@sveneberth sveneberth commented Nov 27, 2024 •
edited
Loading

  • vat rate can now be set per each article AND each country
  • On the article you set the category
  • In VatRate module you assign a percentage to the category (for each country)

@sveneberth sveneberth added Priority: High After critical issues are fixed, these should be dealt with before any further issues. enhancement New feature or request component: skeleton component: module labels Nov 27, 2024
sveneberth
sveneberth commented Dec 3, 2024
View reviewed changes
src/viur/shop/types/enums.py Outdated Show resolved Hide resolved
src/viur/shop/skeletons/cart.py Outdated Show resolved Hide resolved
src/viur/shop/skeletons/cart.py Show resolved Hide resolved
src/viur/shop/skeletons/vat.py Outdated Show resolved Hide resolved
src/viur/shop/types/price.py Show resolved Hide resolved
src/viur/shop/modules/vat_rate.py Show resolved Hide resolved
@sveneberth
Update src/viur/shop/types/enums.py
5890826
@sveneberth
restructure model
67b70aa
@sveneberth
remove shop_vat_rate_percentage, use Price object
7f4e003
@sveneberth
rename
65f964e
@sveneberth
Merge branch 'main' into feature/vat_rate
7d5758d 
 Conflicts:
	src/viur/shop/payment_providers/abstract.py
	src/viur/shop/payment_providers/prepayment.py
	src/viur/shop/types/exceptions.py
@sveneberth
pep8
d5dffd9
@sveneberth sveneberth changed the title feat: Started to rework vat (WIP) feat: Rework vat Dec 3, 2024
@sveneberth sveneberth marked this pull request as ready for review December 3, 2024 17:11
@sveneberth sveneberth merged commit 321297b into viur-framework:main Dec 6, 2024
1 check passed
@sveneberth sveneberth deleted the feature/vat_rate branch December 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akelch akelch akelch approved these changes

@phneutral phneutral Awaiting requested review from phneutral

@ArneGudermann ArneGudermann Awaiting requested review from ArneGudermann

@KadirBalku KadirBalku Awaiting requested review from KadirBalku

Assignees
No one assigned
Labels
component: module component: skeleton enhancement New feature or request Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveneberth @akelch