Fix Renaming Bug

[philippark]

No description provided.

[philippark]

Next on the agenda is to make the styling better looking

[curran]

Thank you for this! I left a comment about a suggested refactoring.

[curran]

Please refactor this so that there is only a single definition of validateFileName in the codebase. I see there is another definition of this over in src/client/VZSidebar/CreateDirModal.tsx. Please pull this function out into its own separate file, then call it from both places. Thanks!

[curran]

Something like this:

export const validateFileName = ({files}) => {
  // Returns true if file name is valid, false otherwise.
  return useCallback(
    (fileName: string) => {
      let valid;
      // General Character Check
      const regex =
        /^[a-zA-Z0-9](?:[a-zA-Z0-9 ./+=_-]*[a-zA-Z0-9])?$/;
      valid = regex.test(fileName);

      // Check for Duplicate Filename
      for (const key in files) {
        if (fileName + '/' === files[key].name) {
          valid = false;
        }
      }

      return valid;
    },
    [files],
  );
}

This is a "custom hook" in React parlance.

[curran]

I'll take it from here. Thanks for this work!

[curran]

Does this close a specific existing issue? If so which one?

[philippark]

Hi, yes it resolves this: #658