Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid potential nil pointers in compare.go #848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhengxiexie
Copy link
Contributor

No description provided.

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/avoid_pentential_nil branch 3 times, most recently from 9857783 to 0d89976 Compare November 1, 2024 02:52
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/avoid_pentential_nil branch from 0d89976 to d87ac10 Compare November 1, 2024 02:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (20379c1) to head (d87ac10).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nsx/services/common/compare.go 26.66% 8 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   64.06%   63.76%   -0.30%     
==========================================
  Files          96       96              
  Lines       15118    15168      +50     
==========================================
- Hits         9685     9672      -13     
- Misses       4742     4802      +60     
- Partials      691      694       +3     
Flag Coverage Δ
unit-tests 63.76% <26.66%> (-0.30%) ⬇️
Files with missing lines Coverage Δ
pkg/nsx/services/common/compare.go 77.08% <26.66%> (-22.92%) ⬇️

... and 3 files with indirect coverage changes

@zhengxiexie
Copy link
Contributor Author

/e2e

7 similar comments
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants