-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the global lock by the SubnetSet lock for Subnet creation #931
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
+ Coverage 73.39% 73.41% +0.01%
==========================================
Files 109 109
Lines 15253 15264 +11
==========================================
+ Hits 11195 11206 +11
Misses 3307 3307
Partials 751 751
|
5f79a21
to
ff59fb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and just one nit. The new lines in pkg/controllers/subnetset/subnetset_controller.go
are not covered by unit-test.
Signed-off-by: Yanjun Zhou <[email protected]>
ff59fb3
to
1918183
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ware-tanzu#931) Signed-off-by: Yanjun Zhou <[email protected]>
…) (#935) Signed-off-by: Yanjun Zhou <[email protected]>
No description provided.