Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the global lock by the SubnetSet lock for Subnet creation #931

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (107a359) to head (1918183).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   73.39%   73.41%   +0.01%     
==========================================
  Files         109      109              
  Lines       15253    15264      +11     
==========================================
+ Hits        11195    11206      +11     
  Misses       3307     3307              
  Partials      751      751              
Flag Coverage Δ
unit-tests 73.41% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
pkg/controllers/common/utils.go 90.41% <100.00%> (+0.61%) ⬆️
pkg/controllers/subnetset/subnetset_controller.go 80.36% <100.00%> (+0.43%) ⬆️

... and 2 files with indirect coverage changes

pkg/controllers/common/utils.go Outdated Show resolved Hide resolved
pkg/controllers/common/utils.go Outdated Show resolved Hide resolved
TaoZou1
TaoZou1 previously approved these changes Nov 25, 2024
Copy link
Contributor

@wenqiq wenqiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and just one nit. The new lines in pkg/controllers/subnetset/subnetset_controller.go are not covered by unit-test.

Copy link
Contributor

@wenqiq wenqiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanjunz97 yanjunz97 merged commit a3a6318 into vmware-tanzu:main Nov 27, 2024
2 checks passed
yanjunz97 added a commit to yanjunz97/nsx-operator that referenced this pull request Nov 29, 2024
yanjunz97 added a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants