Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[artifact-manager] (#552) Custom resource update #555

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[artifact-manager] (#552) Custom resource update #555

wants to merge 9 commits into from
+39 −7

Conversation

Michaelpalacce
Copy link
Collaborator

@Michaelpalacce Michaelpalacce commented Dec 3, 2024 •
edited
Loading

Description

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Related issues and PRs

Closes #552

@Michaelpalacce
refactor: Catching a more general exception.
f71f46e 
It won't work to catch only for Http exception, as a Runtime Exception
is being re-thrown and that way the logic will never hold
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
refactor(error-message): Improved wording
b1f6bc2 
Signed-off-by: Stefan Genov <[email protected]>
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit f0e5759 has a no-reply/unreachable author email address: 49699333+dependabot[bot]@users.noreply.github.com

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit f0e5759 has a no-reply/unreachable author email address: 49699333+dependabot[bot]@users.noreply.github.com

@github-actions github-actions bot added the kind/bug Something isn't working label Dec 3, 2024
akantchev
akantchev reviewed Dec 4, 2024
View reviewed changes
...anager/src/main/java/com/vmware/pscoe/iac/artifact/store/vrang/VraNgCustomResourceStore.java Outdated
final String magicMessage = "Resource type cannot be deleted as there are active resources attached to it";
String message = clientException.getMessage();
return (status == HttpStatus.BAD_REQUEST && message != null && message.indexOf(magicMessage) != -1);
return (message != null && message.indexOf(magicMessage) != -1);
Copy link
Contributor

@akantchev akantchev Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use message.contains(magicMessage) instead of indexOf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit f0e5759 has a no-reply/unreachable author email address: 49699333+dependabot[bot]@users.noreply.github.com

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit f0e5759 has a no-reply/unreachable author email address: 49699333+dependabot[bot]@users.noreply.github.com

@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
f997908 
…re-aria into fix/552-custom-resource-update

Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
Copy link
Collaborator Author

Still need to test this if it's effective, looking for an environment

@VenelinBakalov VenelinBakalov added lang/java Related to Java Code area/artifact-manager Relates to the `artifact-manager` maven module version/patch The change is a non-breaking bugfix labels Dec 4, 2024
@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
d2bf749 
…re-aria into fix/552-custom-resource-update

Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
fix: Make sure to get the full message
2177285 
This is needed because the reason is actually berried in a cause,
instead of being the main exception
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
refactor: Removed unnecessary check
e3b3719 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
docs: Release
2aef886 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce Michaelpalacce marked this pull request as ready for review December 4, 2024 15:48
@Michaelpalacce Michaelpalacce requested a review from a team as a code owner December 4, 2024 15:48
@Michaelpalacce
docs: Add docs to isCustomResourceActiveAttached
e1a9e73 
I feel like we'll forget why we do this in a few weeks
Signed-off-by: Stefan Genov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akantchev akantchev akantchev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/artifact-manager Relates to the `artifact-manager` maven module kind/bug Something isn't working lang/java Related to Java Code version/patch The change is a non-breaking bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vRA Custom Resource push problem
4 participants
@Michaelpalacce @vmwclabot @akantchev @VenelinBakalov