Fix policy docs for different scopes for different policies #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 25.39% 25.31% -0.09%
==========================================
Files 155 156 +1
Lines 13591 13636 +45
==========================================
Hits 3452 3452
- Misses 9982 10027 +45
Partials 157 157
☔ View full report in Codecov by Sentry. |
ramya-bangera
approved these changes
Oct 17, 2023
ishangupta-ds
suggested changes
Oct 17, 2023
shobha2626
suggested changes
Oct 18, 2023
| scope.WithDescription(fmt.Sprintf("Scope for the image policy, having one of the valid scopes: %v.", strings.Join(ScopesAllowed[:], `, `))), | ||
| scope.WithScopes(ScopesAllowed[:])) | ||
| ) | ||
|
|
||
| var imagePolicySchema = map[string]*schema.Schema{ |
There was a problem hiding this comment.
nit: Merge the var blocks together
| scope.WithDescription(fmt.Sprintf("Scope for the network policy, having one of the valid scopes: %v.", strings.Join(ScopesAllowed[:], `, `))), | ||
| scope.WithScopes(ScopesAllowed[:])) | ||
| ) | ||
|
|
||
| var networkPolicySchema = map[string]*schema.Schema{ |
There was a problem hiding this comment.
nit: combine the var together
| var ( | ||
| ScopesAllowed = [...]string{scope.ClusterKey, scope.ClusterGroupKey, scope.OrganizationKey} | ||
| ScopeSchema = scope.GetScopeSchema( | ||
| scope.WithDescription(fmt.Sprintf("Scope for the security policy, having one of the valid scopes: %v.", strings.Join(ScopesAllowed[:], `, `))), |
tenthirtyam
force-pushed
the
main
branch
2 times, most recently
from
0c63249 to
b38b497
Compare
Signed-off-by: vshubhang <[email protected]>
tenthirtyam
force-pushed
the
vshubhang/pollicy
branch
from
b30dbab to
4fed2bc
Compare
|
Rebased and merge conflicts resolved. |
tenthirtyam
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix policy docs for different scopes for different policies