Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected formatting and removed unused types #323

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

grenader
Copy link
Contributor

@grenader grenader commented Nov 2, 2023

Corrected formatting and removed unused types.
This PR is created based on load kubeconfig for AKS feature review.

  1. What this PR does / why we need it:
    fixes minor code quality issues

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7922ec6) 25.69% compared to head (2d16504) 25.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   25.69%   25.69%           
=======================================
  Files         187      187           
  Lines       15775    15775           
=======================================
  Hits         4054     4054           
  Misses      11516    11516           
  Partials      205      205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vmwclabot vmwclabot added the dco-required DCO Required label Nov 2, 2023
@grenader grenader requested a review from asutoshpalai November 3, 2023 14:58
@tenthirtyam tenthirtyam added the needs-review Needs Review label Nov 7, 2024
@tenthirtyam tenthirtyam added this to the Backlog milestone Nov 7, 2024
@tenthirtyam tenthirtyam force-pushed the main branch 2 times, most recently from 0c63249 to b38b497 Compare November 13, 2024 16:56
@tenthirtyam tenthirtyam marked this pull request as draft November 13, 2024 17:08
Igor Kanshyn added 2 commits November 15, 2024 11:51
…onfig for AKS feature review

Signed-off-by: Igor Kanshyn <[email protected]>
…onfig for AKS feature review

Signed-off-by: Igor Kanshyn <[email protected]>
@tenthirtyam tenthirtyam force-pushed the vmware/otaylor/remove-unused-types branch from 2d16504 to 9432535 Compare November 15, 2024 16:51
@vmwclabot vmwclabot removed the dco-required DCO Required label Nov 15, 2024
@github-actions github-actions bot added documentation Documentation provider Provider labels Nov 15, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review November 15, 2024 17:14
@vmware vmware deleted a comment from vmwclabot Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation needs-review Needs Review provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants