diskAttachmentProperties for disk attachment to a VM not exposed

[PaulAngus]

Code of Conduct

This project has a Code of Conduct that all participants are expected to understand and follow:

• I have read and agree to the project's Code of Conduct

Description

The API for attaching a disk to a VM includes diskAttachmentProperties in the schema. This allows the scsiController and unitNumber for the disk to be set.
These parameters cannot be set via the VRA Provder.

Without these options, block devices are attached to a VM in a random order. Operations such as resizing and removal via Terraform and ordered mount of the disks inside the VM aren't possible as it is not possible to determine which disk is which.

Describe alternatives you've considered

NA

References

https://api.mgmt.cloud.vmware.com/iaas-api/swagger/webjars/swagger-ui/index.html#/Compute/attachMachineDisk

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[fieldsta]

Relevant, and likely not all, areas of interest to this request:

https://github.com/vmware/terraform-provider-vra/blob/main/vra/resource_machine.go#L74-L121
Exposing the parameter schema for disks and disks_list.

"disk_attachment_properties": {
	Type:        schema.TypeMap,
	Required:    false,
	Description: "Disk Attachment specific properties.",
},

https://github.com/vmware/terraform-provider-vra/blob/main/vra/resource_machine.go#L481-L486
Including the DiskAttachmentProperties to the diskAttachmentSpecification.

DiskAttachmentProperties: diskToAttach["disk_attachment_properties"].(map[string]string),