feat: SCSI controller and unit number support, attach disks on build

[ZsoltFejes]

• Feature added based on request: diskAttachmentProperties for disk attachment to a VM not exposed #538 To be able to specify scsi controller and unit for block device attach
• Added support for attaching disks on build

Closes #538

[ZsoltFejes]

Tests I carried out

• One disk with valid controller and unit, and attach before boot set to true - Disk is attached during build correctly to the specified controller and unit
• One disk with correct controller and unit, and attach before boot set to true - Disk was attached to the correct controller and unit after the VM was built
• One disk with correct controller but no unit - Default Aria automation behaviour, attached disk to the root disk’s controller and the next available unit
• One disk with missing controller specified but unit is specified - Default aria behaviour, attached disk to the root disk’s controller and the next available unit
• Two disks with the same controller and unit - Aria failed to attach the second disk, returned error stating unable to attach controller and unit number is already attached
• Two disks, one disk was specified with controller and unit number the second disk wasn’t - Disk with specified placement was correct, the one without placement was attached to the controller of the root disk to the next available unit

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]
• Commit fb58652 has a no-reply/unreachable author email address: [email protected]

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]
• Commit fb58652 has a no-reply/unreachable author email address: [email protected]
• Commit 662ab59 has a no-reply/unreachable author email address: [email protected]

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]
• Commit fb58652 has a no-reply/unreachable author email address: [email protected]
• Commit 662ab59 has a no-reply/unreachable author email address: [email protected]
• Commit 23ad13a has a no-reply/unreachable author email address: [email protected]

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]
• Commit fb58652 has a no-reply/unreachable author email address: [email protected]
• Commit 662ab59 has a no-reply/unreachable author email address: [email protected]
• Commit 23ad13a has a no-reply/unreachable author email address: [email protected]
• Commit 11737f2 has a no-reply/unreachable author email address: [email protected]

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]
• Commit fb58652 has a no-reply/unreachable author email address: [email protected]
• Commit 662ab59 has a no-reply/unreachable author email address: [email protected]
• Commit 23ad13a has a no-reply/unreachable author email address: [email protected]
• Commit 11737f2 has a no-reply/unreachable author email address: [email protected]
• Commit d49de16 has a no-reply/unreachable author email address: [email protected]

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]
• Commit fb58652 has a no-reply/unreachable author email address: [email protected]
• Commit 662ab59 has a no-reply/unreachable author email address: [email protected]
• Commit 23ad13a has a no-reply/unreachable author email address: [email protected]
• Commit 11737f2 has a no-reply/unreachable author email address: [email protected]
• Commit d49de16 has a no-reply/unreachable author email address: [email protected]
• Commit 9133516 has a no-reply/unreachable author email address: [email protected]

[vmwclabot]

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2d89182 has a no-reply/unreachable author email address: [email protected]
• Commit fb58652 has a no-reply/unreachable author email address: [email protected]
• Commit 662ab59 has a no-reply/unreachable author email address: [email protected]
• Commit 23ad13a has a no-reply/unreachable author email address: [email protected]
• Commit 11737f2 has a no-reply/unreachable author email address: [email protected]
• Commit d49de16 has a no-reply/unreachable author email address: [email protected]
• Commit 9133516 has a no-reply/unreachable author email address: [email protected]
• Commit f9ba664 has a no-reply/unreachable author email address: [email protected]