Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Set as attribute type for unordered list of items #411

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

frodenas
Copy link
Member

TypeList represents an ordered collection of items. TypeSet represents an unordered collection of items.

Switching attributes to Set when order does not matter. This will fix an issue when repeated applies without
any changes try to update the resource due to a list of items in a different order.

See related issue #358.

Signed-off-by: Ferran Rodenas [email protected]

TypeList represents an ordered collection of items.
TypeSet represents an unordered collection of items.

Switching attributes to Set when order does not matter.
This will fix an issue when repeteaded applies without
any changes tries to update the resource due to a list
of items in a different order.

Signed-off-by: Ferran Rodenas <[email protected]>
Copy link
Contributor

@dondon3345678 dondon3345678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frodenas frodenas merged commit bcf0591 into main Nov 1, 2021
@frodenas frodenas deleted the fix-type-list branch November 1, 2021 17:19
@vmware vmware locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants