fix: add vra_deployment.recreate_if_expired_at attribute

[azrdev]

see #473 especially #473 (comment)

[azrdev]

DCO signed. before merge, please note the alternatives described in the linked issue comment

[azrdev]

What is missing for this to be merged (or #473 to be fixed some other way)? Can I do something?

Edit: @frodenas would you be able to review & merge my patch?

[azrdev]

Rebased to current main due to merge conflict. @tenthirtyam you assigned me, but I have no permissions to merge here / need a review by some maintainer. Who's able to do that?

[tenthirtyam]

Suggesting a change as follows that would be a bit more simplified and idiomatic.

CustomizeDiff: customdiff.ForceNewIf(
    "recreate_if_expired_at",
    func(ctx context.Context, d *schema.ResourceDiff, meta interface{}) bool {
        planTime, valid := getParsedTime(d, "recreate_if_expired_at")
        if !valid {
            return false
        }
        expirationTime, valid := getParsedTime(d, "lease_expire_at")
        if !valid {
            return false
        }
        return expirationTime.Before(planTime)
    }
),

and

func getParsedTime(d *schema.ResourceDiff, key string) (time.Time, bool) {
    timeStr, ok := d.GetOk(key)
    if !ok {
        log.Printf("[INFO] Missing or invalid time string for key %s: %#v", key, timeStr)
        return time.Time{}, false
    }
    parsedTime, err := strfmt.ParseDateTime(timeStr.(string))
    if err != nil {
        log.Printf("[INFO] Failed to parse DateTime for key %s: %#v", key, timeStr)
        return time.Time{}, false
    }
    return time.Time(parsedTime), true
}