-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carla: update to 2.5.9, adopt. #52860
base: master
Are you sure you want to change the base?
Conversation
Carla depends on
If nobody has noticed, maybe
Please choose one of those alternatives. |
Thank you for your suggestions, @ahesford! I have ported the pyliblo3 package following the second recommendation, where I had to create the template using the commit due to the lack of a tag for the latest version on GitHub. I also looked on the Pip website, but the source version wasn't listed, so I decided to use the latest commit from the repository as the closest option. For the Carla package, I applied the patch to switch the liblo dependency to pyliblo3, as recommended, following the logic employed in the pull request mentioned above. I also had to rebase on top of the master branch to include the latest version of Wine. Re-edit: I added a patch that possibly fixes the build for Python 3.13, based on a pull request in the repository (gesellkammer/pyliblo3#11). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize when I recommended this that upstream pyliblo3
doesn't tag source releases. To make matters worse, the maintainer doesn't seem all that responsive to issues.
It turns out the patches to make pyliblo
build with Cython 3 and Python 3.13 are pretty trivial, so if you want to defer the pyliblo3
addition for now, that's fine. Sorry for the runaround.
Thank you for the clarification, @ahesford. Initially, I applied the full patch for Python 3.13 compatibility, but it included the removal of an autogenerated file, which caused the .patch file to become excessively large and the fact that we are still on Python 3.12. After seeing the pull request for Python 3.13 in Void, I decided to revisit the issue and reapplied a minimal version of the patch. This time, I included only the necessary changes and handled the file removal directly in the template using rm. This approach keeps the patch concise while implementing the required adjustments for Python 3.13 compatibility. That said, I haven’t tested the build with Python 3.13 yet, as it hasn’t been merged into the master branch. If you think it's best, the pull request can remain open until Python 3.13 is officially merged into the master branch. Once that happens, I can rebase my changes and verify that everything compiles as expected with the updated Python version. Please let me know how you’d like to proceed |
Testing the changes
Local build testing
New Package Details
python3-pyliblo3
, including a patch to possibly fix the build for Python 3.13 and ensure compatibility.Patch Details
Carla
package to acceptpyliblo3
as the dependency instead ofliblo
(pyliblo).