Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: update to 3.0.1. #53119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryanasdev000
Copy link

@bryanasdev000 bryanasdev000 commented Nov 18, 2024

Testing the changes

  • I tested the changes in this PR: Yes, running on my homelab

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Note

Although 3.x is available, Prometheus 2.55 or newer "required" for a major (3.x) upgrade, per migration guide (https://prometheus.io/docs/prometheus/3.0/migration/#tsdb-format-and-downgrade).

@bryanasdev000
Copy link
Author

bryanasdev000 commented Nov 18, 2024

Also, a question, for the 3.x release, a separated packaged would be needed?

Current release is 3.0.0, previously 2.55.1, current LTS is 2.53.3.

@bryanasdev000
Copy link
Author

Is possible to retry tests on i686?

Did not find an error.

@TinfoilSubmarine
Copy link
Contributor

Although 3.x is available, Prometheus 2.55 or newer "required" for a major (3.x) upgrade, per migration guide (https://prometheus.io/docs/prometheus/3.0/migration/#tsdb-format-and-downgrade).

Are you sure this assumption is correct? The linked guide doesn't say anything about needing >=2.55 to upgrade to v3. It only says that >=2.55 is needed when downgrading from v3.

@bryanasdev000
Copy link
Author

Although 3.x is available, Prometheus 2.55 or newer "required" for a major (3.x) upgrade, per migration guide (https://prometheus.io/docs/prometheus/3.0/migration/#tsdb-format-and-downgrade).

Are you sure this assumption is correct? The linked guide doesn't say anything about needing >=2.55 to upgrade to v3. It only says that >=2.55 is needed when downgrading from v3.

Bad wording on my part, sorry.

AFAIK is not required to have 2.55 to upgrade (thought the two upgrades that I did, I was on 2.55), in this case I put it as "required" and the asked how to proceed in void packages because is a major upgrade, and as I have understood, there will be multiple versions being supported at the same time (at least 2, if I understood correctly, the 2.x LTS and 3.x now).

So in case things go wrong, users have a way to downgrade and recover.

@TinfoilSubmarine
Copy link
Contributor

as I have understood, there will be multiple versions being supported at the same time (at least 2, if I understood correctly, the 2.x LTS and 3.x now).

So in case things go wrong, users have a way to downgrade and recover.

LTS versions aren't always packaged, especially if there is no/minimal breakage. The prometheus package doesn't have any dependents so this is a good sign that IMO it could just be upgraded to v3 and not have to bifurcate into two packages.

Was there a specific reason you thought we would need both versions packaged?

@bryanasdev000
Copy link
Author

as I have understood, there will be multiple versions being supported at the same time (at least 2, if I understood correctly, the 2.x LTS and 3.x now).
So in case things go wrong, users have a way to downgrade and recover.

LTS versions aren't always packaged, especially if there is no/minimal breakage. The prometheus package doesn't have any dependents so this is a good sign that IMO it could just be upgraded to v3 and not have to bifurcate into two packages.

Was there a specific reason you thought we would need both versions packaged?

Only if the user wants to be in the LTS or if things goes wrong on the update.

Myself will use 3.x

@bryanasdev000
Copy link
Author

Built 3.0.1 locally and will see how it goes.

Need to fix consoles on 3.0.1 and understand why tests are failing for both, 2.55.1 and 3.0.1 if I rebase to master.

@TinfoilSubmarine
Copy link
Contributor

TinfoilSubmarine commented Dec 2, 2024

From the prometheus changelog:

[CHANGE] Console: Remove example files for the console feature. Users can continue using the console feature by supplying their own JavaScript and templates. #14807

So you can just remove those two lines:

        vcopy consoles etc/prometheus
        vcopy console_libraries etc/prometheus

@bryanasdev000
Copy link
Author

From the prometheus changelog:

[CHANGE] Console: Remove example files for the console feature. Users can continue using the console feature by supplying their own JavaScript and templates. #14807

So you can just remove those two lines:

        vcopy consoles etc/prometheus
        vcopy console_libraries etc/prometheus

I saw this, but it looks like I tested the wrong container image as I swore I saw /consoles/index.html.example in 3.0.0.

Anyway, I'll delete these items, thanks.

@bryanasdev000 bryanasdev000 changed the title prometheus: update to 2.55.1. prometheus: update to 3.0.1. Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants