This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Registering VideoControllers bug #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… local player The ConferenceController was set to return after finding the VideoController that was local. This meant any remote participants AFTER this point did not get their VideoTrack assigned.
|
Hi @leeprobert! ProcessIn order for us to review and merge your suggested changes, please sign at https://contribute.dolby.io. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. |
|
I also added a public method to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConferenceController RegisterVideoControllers would break out of the iteration of VideoControllers after it found the local player. This prevented any other remote players from having their VideoTrack assigned.