Improve data types #193
Open
Improve data types #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
improve-data-types
branch
3 times, most recently
from
5f1293b to
1bd0acc
Compare
A negative value or 0 are not valid and should not be accepted by the module.
In a future major version, we will remove the support for non-sensitive passwords and stop providing a default value for them.
All user provided String are expected to be non-empty when they are not undef.
smortex
force-pushed
the
improve-data-types
branch
from
1bd0acc to
b9a9dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some data types allow invalid values. Tighten the data types to make it harder to build broken configuration.