-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Console section to the Director configuration #210
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added some inline notes for review. Also it would be great to rebase on top of master to get rid of this merge commit.
a0ae1a5
to
5c87f03
Compare
5c87f03
to
e29c622
Compare
79c4bd7
to
e63582b
Compare
e63582b
to
493e2bf
Compare
b623b58
to
fa8ff5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few commit in your branch to "hide" the complex data type away from the console code, and add a basic unit test.
Are you happy with these changes?
Also, I added some in-line comments regarding quoting.
This PR allows to add Console sections to the Director configuration. This is useful if one needs to force ACL for example for monitoring purposes.
This is done via define of a new collected resource
bacula::director::console
.I found out that the CatalogACL and CommandACL need to be defined as the bare minimum to get anything working. Other parameters are therefore optional.