Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Console section to the Director configuration #210

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lemrouch
Copy link

This PR allows to add Console sections to the Director configuration. This is useful if one needs to force ACL for example for monitoring purposes.
This is done via define of a new collected resource bacula::director::console.
I found out that the CatalogACL and CommandACL need to be defined as the bare minimum to get anything working. Other parameters are therefore optional.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added some inline notes for review. Also it would be great to rebase on top of master to get rid of this merge commit.

manifests/director/console.pp Outdated Show resolved Hide resolved
manifests/director/console.pp Outdated Show resolved Hide resolved
manifests/director/console.pp Outdated Show resolved Hide resolved
manifests/director/console.pp Outdated Show resolved Hide resolved
@lemrouch lemrouch force-pushed the director-console branch 2 times, most recently from a0ae1a5 to 5c87f03 Compare June 19, 2024 11:14
@smortex smortex force-pushed the director-console branch from e63582b to 493e2bf Compare June 19, 2024 23:58
@smortex smortex force-pushed the director-console branch from b623b58 to fa8ff5a Compare June 20, 2024 00:04
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few commit in your branch to "hide" the complex data type away from the console code, and add a basic unit test.

Are you happy with these changes?

Also, I added some in-line comments regarding quoting.

spec/defines/director_console_spec.rb Show resolved Hide resolved
@smortex smortex self-requested a review June 21, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants