Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort kernelrelease fact #1139

Conversation

ArthurWuTW
Copy link
Contributor

solve issue #731

  • implement natural sorting for fact=kernelrelease
  • create a sorter_map with key=fact and value=sorter type, now having (kernelrelease, natural) and (uptime, natural-time-delta)
  • remove natural_time_delta_sort flag

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.89%. Comparing base (b8e1467) to head (c457ece).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   76.87%   76.89%   +0.02%     
==========================================
  Files          20       20              
  Lines        1310     1307       -3     
==========================================
- Hits         1007     1005       -2     
+ Misses        303      302       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArthurWuTW ArthurWuTW changed the title Get value sorter type by fact itself when datatable_init Sort kernelrelease fact Aug 1, 2024
@bastelfreak bastelfreak force-pushed the puppetboard-sorting-kernelrelease-fact branch from cbe67d3 to c457ece Compare November 26, 2024 08:35
@bastelfreak
Copy link
Member

I rebased it and fixed the trailing newline.

@bastelfreak bastelfreak merged commit 9d014d6 into voxpupuli:master Nov 26, 2024
16 checks passed
@ArthurWuTW ArthurWuTW deleted the puppetboard-sorting-kernelrelease-fact branch November 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants