Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sponsoredCount-prop #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hiagolcm
Copy link
Contributor

What problem is this solving?

Currently, the maximum number of sponsoredProducts is hardcoded. This PR allows the developer to change it via store-theme. For example:

"store.search": {
    "blocks": ["search-result-layout"],
    "props": {
      "context": {
        "sponsoredCount": 4
      }
    }
  },

It also removes the sponsoredProductsBehavior which is a deprecated prop.

How to test it?

Workspace

Related to / Depends on

vtex-apps/search-result#691

@hiagolcm hiagolcm requested a review from a team as a code owner November 29, 2024 13:00
@hiagolcm hiagolcm requested review from vsseixaso, RodrigoTadeuF and leo-prange-vtex and removed request for a team November 29, 2024 13:00
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 29, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 29, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant