Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specific builder config to override the common config for pinned dependencies #1209

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

mairatma
Copy link
Contributor

What is the purpose of this pull request?

Change the logic that handles pinned dependencies to allow configs for specific builders to have higher precedence than the common configs.

This won't cause any problems, since the Typescript is currently the only common pinned dep and there are currently no builders trying to change its value either. You can see the current pinned dependencies config here.

What problem is this solving?

With the current logic it's impossible to allow other Typescript versions to be used in any builders. A new node builder major is being created (PR here) to upgrade TS and it needs this change to properly work.

How should this be manually tested?

First test the existing use cases:

  1. Load the repo of an existing Node.js app.
  2. Bump typescript to ^5.0.0 within the app's node/package.json.
  3. Link the app with this version of the toolbelt.
  4. Verify that the typescript version was fixed back to 3.9.7.

Afterwards, you can test with the new builder:

  1. Link the builder-hub version in this PR.
  2. Change the app's manifest.json to point to the new builder.
  3. Bump @types/node to ^16.0.0 within the app's node/package.json.
  4. Bump typescript to ^5.0.0 within the app's node/package.json.
  5. Link the app with this version of the toolbelt.
  6. Verify that the typescript version was not changed back to 3.9.7.

Screenshots or example usage

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@mairatma mairatma marked this pull request as ready for review January 31, 2024 19:06
@iagoaraujo iagoaraujo merged commit 6af50b2 into main Jul 30, 2024
4 checks passed
@iagoaraujo iagoaraujo deleted the node16 branch July 30, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants