Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accelerate example #446

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

edbeeching
Copy link

Description

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the tests accordingly (if applicable).
  • I have updated the documentation and previewed the changes via mkdocs serve.
    • I have explained note-worthy implementation details.
    • I have explained the logged metrics.
    • I have added links to the original paper and related papers.

If you need to run benchmark experiments for a performance-impacting changes:

  • I have contacted @vwxyzjn to obtain access to the openrlbenchmark W&B team.
  • I have used the benchmark utility to submit the tracked experiments to the openrlbenchmark/cleanrl W&B project, optionally with --capture_video.
  • I have performed RLops with python -m openrlbenchmark.rlops.
    • For new feature or bug fix:
      • I have used the RLops utility to understand the performance impact of the changes and confirmed there is no regression.
    • For new algorithm:
      • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves generated by the python -m openrlbenchmark.rlops utility to the documentation.
    • I have added links to the tracked experiments in W&B, generated by python -m openrlbenchmark.rlops ....your_args... --report, to the documentation.

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cleanrl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 10:28pm

Copy link
Owner

@vwxyzjn vwxyzjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I had something quick whip up here https://gist.github.com/vwxyzjn/62197ac158bfa648e3251994bf8ccd3e and made a comparison and added some comments :)

cleanrl/ppo_atari_accelerate.py Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Outdated Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Outdated Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Outdated Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Outdated Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Outdated Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Outdated Show resolved Hide resolved
cleanrl/ppo_atari_accelerate.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants