Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6357: check pr labels #2

Merged
merged 1 commit into from
May 22, 2024
Merged

T6357: check pr labels #2

merged 1 commit into from
May 22, 2024

Conversation

kumvijaya
Copy link
Collaborator

@kumvijaya kumvijaya commented May 22, 2024

check pr labels

Change Summary

check pr labels

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6357

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@kumvijaya kumvijaya changed the title T6357: check pr lablels T6357: check pr labels May 22, 2024
@kumvijaya kumvijaya force-pushed the feature/pr-checks branch 2 times, most recently from 816ebe5 to bc75c4f Compare May 22, 2024 05:37
@c-po
Copy link
Member

c-po commented May 22, 2024

You should remove the branch protection rules here so you can have fast test cycles

@sever-sever sever-sever merged commit 4d57bbb into current May 22, 2024
8 checks passed
@kumvijaya
Copy link
Collaborator Author

You should remove the branch protection rules here so you can have fast test cycles

Sure. Just raised this PR for testing the checks, test codeowner, etc.

Will remove the protection. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants