-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change getComposedRanges to have options as input #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me from a Chromium perspective and in terms of spec consistency with other similarly shaped APIs. The web platform design principles also support this updated syntax: https://www.w3.org/TR/design-principles/#prefer-dictionaries.
However, it might be good to get an official resolution on this change from the Editing WG before landing the PR. cc: @johanneswilm
The WPT test changes are at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also change the definition of this function to refer to options.shadowRoots
instead of shadowRoots
.
2a1070c
to
88a6701
Compare
6ec7917
to
5e940da
Compare
Closes #176
Implementation commitment:
getComposedRanges
'sshadowRoots
parameter from rest parameter to a dictionary #176 (comment)) (caveat web compat)getComposedRanges
'sshadowRoots
parameter from rest parameter to a dictionary #176 (comment))getComposedRanges
'sshadowRoots
parameter from rest parameter to a dictionary #176 (comment))Preview | Diff