Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change getComposedRanges to have options as input #331

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

@dizhang168
Copy link
Member Author

@rniwa @sanketj

Please help review, thanks!

Copy link
Member

@sanketj sanketj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me from a Chromium perspective and in terms of spec consistency with other similarly shaped APIs. The web platform design principles also support this updated syntax: https://www.w3.org/TR/design-principles/#prefer-dictionaries.

However, it might be good to get an official resolution on this change from the Editing WG before landing the PR. cc: @johanneswilm

@johanneswilm johanneswilm added the Agenda+ Queue this item for discussion at the next WG meeting label Aug 8, 2024
@dizhang168
Copy link
Member Author

The WPT test changes are at:
web-platform-tests/wpt#47523

Copy link

@dandclark dandclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also change the definition of this function to refer to options.shadowRoots instead of shadowRoots.

@dizhang168 dizhang168 force-pushed the getComposedRanges-dict branch from 2a1070c to 88a6701 Compare September 27, 2024 16:02
index.html Outdated Show resolved Hide resolved
@dizhang168 dizhang168 force-pushed the getComposedRanges-dict branch from 6ec7917 to 5e940da Compare September 30, 2024 00:52
@annevk annevk merged commit c0071c7 into w3c:gh-pages Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+ Queue this item for discussion at the next WG meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change getComposedRanges's shadowRoots parameter from rest parameter to a dictionary
5 participants