fix(ThingDiscoveryProcess): clarify usage of url field #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes over the commit discussed under #551 (comment). However, I already adjusted it insofar that I removed the adjustments of the constructor, not adding an optional
urlparameter.However, since the field is set "externally" in the current
exploreDirectoryalgorithm, I think it would still make sense to adjust the data structure here to make it "less mutable" if not immutable if possible. If I see it correctly, one way to achieve this in WebIDL could be defining a second constructor with a mandatory URL parameter. Maybe this something we could discuss in today's call.Preview | Diff