Fix rounding error between triangle area calculation and intersection calculation #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both the triangle area calculation in
signed_area.js
and the intersection calculation insegment_intersection.js
are used to determine if two line segments are collinear. A signed area of 0 indicates collinearity, while a intersection calculation of 2 also indicates collinearity.Segment intersection is used here while signed area is used here and here.
It's possible (due to rounding errors) for the signed area calculation to return a non-zero result (indicating the segments are not collinear) while for the same two line segments, the intersection calculation will calculate two intersections (indicating the segments are collinear). When this happens, segments can get inserted into the sweep line but never removed - messing up order of segments in the sweep line which in turn messes up the calculation of whether other line segments should be included in the final result or not.
This PR adds a test case demonstrating that sutiation, and implements a fix.