Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle https, add some convenience methods #15

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

biering
Copy link
Collaborator

@biering biering commented Dec 20, 2024

  • handle https and improve gateway creation
  • conform env variables from ADX
  • added tcps() and tcp_names() method
  • added controllers() method
  • make tcp in get_state() optional -> returns flange pose
  • updated examples accordingly

@biering biering self-assigned this Dec 20, 2024
Copy link
Collaborator

@langenhagen langenhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

examples/03_move_and_set_ios.py Show resolved Hide resolved
examples/02_plan_and_execute.py Show resolved Hide resolved
@@ -44,6 +44,32 @@ def current_motion(self) -> str:
# raise ValueError("No MotionId attached. There is no planned motion available.")
return self._current_motion

async def plan(self, actions: list[Action], tcp: str) -> wb.models.JointTrajectory:
current_joints = await self.joints(tcp=tcp)
robot_setup = await self._get_optimizer_setup(tcp=tcp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be cached?

nova/core/motion_group.py Outdated Show resolved Hide resolved
@@ -176,3 +162,36 @@ async def stop(self):
logger.debug(f"Motion {self.current_motion} stopped.")
except ValueError as e:
logger.debug(f"No motion to stop for {self}: {e}")

async def get_state(self, tcp: str | None) -> wb.models.MotionGroupStateResponse:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there also the option for a state fetching via websocket?

nova/gateway.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants