Introduce isnan helper

wasmx · Jun 20, 2022 · a5edb7c · a5edb7c
1 parent 71d4b4a
commit a5edb7c
Showing 1 changed file with 27 additions and 8 deletions.
diff --git a/lib/fizzy/execute.cpp b/lib/fizzy/execute.cpp
@@ -26,6 +26,10 @@ constexpr uint32_t F32AbsMask = 0x7fffffff;
 constexpr uint32_t F32SignMask = ~F32AbsMask;
 constexpr uint64_t F64AbsMask = 0x7fffffffffffffff;
 constexpr uint64_t F64SignMask = ~F64AbsMask;
+constexpr uint32_t F32ExpMask = 0x7f800000;
+constexpr uint32_t F32FracMask = 0x007fffff;
+constexpr uint64_t F64ExpMask = 0x7ff0000000000000;
+constexpr uint64_t F64FracMask = 0x000fffffffffffff;
 
 template <typename T>
 inline T read(const uint8_t*& input) noexcept
@@ -346,6 +350,21 @@ inline bit_cast_constexpr bool signbit(double value) noexcept
     return (bit_cast<uint64_t>(value) & F64SignMask) != 0;
 }
 
+template <typename T>
+T isnan(T value) noexcept = delete;
+
+inline bit_cast_constexpr bool isnan(float value) noexcept
+{
+    const auto v = bit_cast<uint32_t>(value);
+    return ((v & F32ExpMask) == F32ExpMask) && ((v & F32FracMask) != 0);
+}
+
+inline bit_cast_constexpr bool isnan(double value) noexcept
+{
+    const auto v = bit_cast<uint64_t>(value);
+    return ((v & F64ExpMask) == F64ExpMask) && ((v & F64FracMask) != 0);
+}
+
 template <typename T>
 T fabs(T value) noexcept = delete;
 
@@ -399,7 +418,7 @@ template <typename T>
 inline T fceil(T value) noexcept
 {
     static_assert(std::is_floating_point_v<T>);
-    if (std::isnan(value))
+    if (isnan(value))
         return std::numeric_limits<T>::quiet_NaN();  // Positive canonical NaN.
 
     // The FE_INEXACT error is ignored (whenever the implementation reports it at all).
@@ -410,7 +429,7 @@ template <typename T>
 inline T ffloor(T value) noexcept
 {
     static_assert(std::is_floating_point_v<T>);
-    if (std::isnan(value))
+    if (isnan(value))
         return std::numeric_limits<T>::quiet_NaN();  // Positive canonical NaN.
 
     // The FE_INEXACT error is ignored (whenever the implementation reports it at all).
@@ -429,7 +448,7 @@ template <typename T>
 inline T ftrunc(T value) noexcept
 {
     static_assert(std::is_floating_point_v<T>);
-    if (std::isnan(value))
+    if (isnan(value))
         return std::numeric_limits<T>::quiet_NaN();  // Positive canonical NaN.
 
     // The FE_INEXACT error is ignored (whenever the implementation reports it at all).
@@ -441,7 +460,7 @@ T fnearest(T value) noexcept
 {
     static_assert(std::is_floating_point_v<T>);
 
-    if (std::isnan(value))
+    if (isnan(value))
         return std::numeric_limits<T>::quiet_NaN();  // Positive canonical NaN.
 
     // Check if the input integer (as floating-point type) is even.
@@ -467,11 +486,11 @@ __attribute__((no_sanitize("float-divide-by-zero"))) inline constexpr T fdiv(T a
 }
 
 template <typename T>
-inline T fmin(T a, T b) noexcept
+inline bit_cast_constexpr T fmin(T a, T b) noexcept
 {
     static_assert(std::is_floating_point_v<T>);
 
-    if (std::isnan(a) || std::isnan(b))
+    if (isnan(a) || isnan(b))
         return std::numeric_limits<T>::quiet_NaN();  // Positive canonical NaN.
 
     if (a == 0 && b == 0 && (signbit(a) || signbit(b)))
@@ -481,11 +500,11 @@ inline T fmin(T a, T b) noexcept
 }
 
 template <typename T>
-inline T fmax(T a, T b) noexcept
+inline bit_cast_constexpr T fmax(T a, T b) noexcept
 {
     static_assert(std::is_floating_point_v<T>);
 
-    if (std::isnan(a) || std::isnan(b))
+    if (isnan(a) || isnan(b))
         return std::numeric_limits<T>::quiet_NaN();  // Positive canonical NaN.
 
     if (a == 0 && b == 0 && (!signbit(a) || !signbit(b)))