Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tms support #19

Merged
merged 10 commits into from
Mar 25, 2024
Merged

added tms support #19

merged 10 commits into from
Mar 25, 2024

Conversation

Modif93
Copy link
Contributor

@Modif93 Modif93 commented Mar 19, 2024

TMS url support added by using lngLatToTile() in package global-mercator

since my custom terrain tile for MapLibre GL JS is TMS, I needed to add function for this library.

@JinIgarashi
Copy link
Member

@Modif93 This looks great. Could you add few test cases for TMS tile? Also please fix error in CI

src/tile/base.ts Outdated Show resolved Hide resolved
Copy link
Member

@JinIgarashi JinIgarashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Modif93 This change now looks good. If possible, could you add some description about TMS option in README.md?

@JinIgarashi JinIgarashi merged commit 41574ff into watergis:main Mar 25, 2024
1 check passed
@JinIgarashi
Copy link
Member

@Modif93 I released v1.2.0. https://github.com/watergis/terrain-rgb/releases/tag/v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants