feat(vue-script-setup-converter): Convert page meta into definePageMeta #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wattanx
approved these changes
May 5, 2024
| @@ -53,6 +55,10 @@ export const convertSrc = (input: string) => { | |||
| .map((x) => x.getText()) | |||
| ); | |||
|
|
|||
| if (isDefineNuxtComponent(callexpression)) { | |||
There was a problem hiding this comment.
I think this is fine at first, but eventually it would be better to have a drop down to select whether nuxt or not.
wattanx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to be solved
When converting Nuxt page components using the Vue Script Setup Converter, information such as name, layout and middleware is lost.
I want to take over these information using the definePageMeta function.
Note
Whether or not a Nuxt page component is a Nuxt page component is determined by defineNuxtComponent or not.