feat(vue-script-setup-converter): Remove defineComponent from import declaration #53
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1,3 +1,4 @@ | |||
| // TODO: Move to helpers/node.ts | |||
There was a problem hiding this comment.
I will handle this in another Pull Request 🙏
| .map((x) => { | ||
| if (x.isKind(SyntaxKind.ImportDeclaration)) { | ||
| if (hasNamedImportIdentifier(x, "defineComponent")) { | ||
| removeNamedImportIdentifier(x, "defineComponent"); |
There was a problem hiding this comment.
It may be better to extract only the ImportDeclaration and insert it later.
(I don't want to rewrite the original sorce.)
There was a problem hiding this comment.
(I don't want to rewrite the original sorce.)
Pros.
I thought so too, but chose to rewrite the original once, because no real harm would come from rewriting the original at this time, and because duplicating the importDeclaration would have been somewhat tedious.
However, on second thought, I decided that it could be a breeding ground for bugs in the future, so I will fix it.
😺
| import type { ImportDeclaration, SourceFile } from "ts-morph"; | ||
| import { hasNamedImportIdentifier } from "../helpers/module"; | ||
|
|
||
| export const convertDefineComponentImport = (sourceFile: SourceFile) => { |
There was a problem hiding this comment.
I don't think it is a convert to defineComponent.
| export const convertDefineComponentImport = (sourceFile: SourceFile) => { | |
| export const convertImportDeclaration = (sourceFile: SourceFile) => { |
| @@ -41,6 +43,7 @@ export const convertSrc = (input: string) => { | |||
| throw new Error("defineComponent is not found."); | |||
| } | |||
|
|
|||
| const defineComponentImport = convertDefineComponentImport(sourceFile) ?? ""; | |||
There was a problem hiding this comment.
Looking here, convertDefineComponentImport looks good. I prefer converterImportDeclaration to defineComponentImport.
…ComponentImportConverter.ts -> packages/vue-script-setup-converter/src/lib/converter/importDeclarationConverter.ts
inouetakuya
deleted the
feat-vue-script-setup-converter-remove-define-component
branch
Remove defineComponent from import declaration because the converted code does not need to import defineComponent.