Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong scroll action specification in the prompts vs. in the parsing function #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michalspiegel
Copy link

Hi, I'm reporting just a small bug, the prompts all say to use "scroll [direction=up|down]" but the parsing function expects "scroll [up|down]". This way the parsing always fails for the scroll action because the model always generates "scroll [direction=up|down]".

@frankxu2004
Copy link
Collaborator

@shuyanzhou

@frankxu2004 frankxu2004 requested a review from shuyanzhou April 15, 2024 05:19
@michalspiegel
Copy link
Author

On the other hand, judging from you GPT4 experiment logs, this was not a problem for GPT4. Maybe this is just specific for the Gemini I was using. It always tried to generate the action in the wrong format, e.g. scroll [direction=down]. In that case this issue might be irrelevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants