Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix pop menu #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lwaekfjlk
Copy link
Member

No description provided.

@lwaekfjlk
Copy link
Member Author

solve #89

@dragon18456
Copy link

We have noticed this issue as well, is this caused by newer version of playwright?

@lwaekfjlk
Copy link
Member Author

I am not sure. I think that is because playwright just cannot capture those popmenus? Maybe @shuyanzhou can provide more reasons on why this happens.

Basically I try to provide a dirty solution to hard-code this part. Do you have any other suggestions?

@shuyanzhou
Copy link
Contributor

I can confirm this is an issue from Playwright.
There is a solution in the issue I posted. I will test it and follow up soon

@dragon18456
Copy link

Thanks @shuyanzhou

@lwaekfjlk As far as I can tell, this bug affects the shopping website and the maps website. Are there any other tasks that have this issue?

@shuyanzhou
Copy link
Contributor

Yes. @dragon18456 This bug affects sorting products and selecting transportation modes. We tested other dropdown menus such as ones on the admin store portal, and found no problem. Feel free to follow up if you discover new problems. Thanks!

@dragon18456
Copy link

One issue I found is that on the bestsellers report page in the shopping_admin website, the dropdowns for the period does not render when the dropdown is open. The agent is unable to select the proper period i.e. year, month, or day for the range, which make some of the first couple of tasks nearly impossible. @shuyanzhou @lwaekfjlk

@lwaekfjlk
Copy link
Member Author

good point :-)

@dragon18456
Copy link

I have also tried changing device_scale_factor=2 as posted in the issue above that @shuyanzhou mentioned, but this does not solve the problem. is this a new problem with playwright? Is there perhaps a version that I can downgrade to to make this issue go away? @lwaekfjlk

@shuyanzhou
Copy link
Contributor

Hi @dragon18456 Thanks for reporting this one. I plan to follow @lwaekfjlk's fix and fix all these known issues. I have tested two or three versions of playwright before, but all have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants