Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic structure for dialog light dismiss [1/N] #48976

Merged
merged 1 commit into from
Nov 5, 2024

Commits on Nov 5, 2024

  1. Implement basic structure for dialog light dismiss [1/N]

    This CL puts the feature flag in place, adds (flag guarded) closedBy
    and requestClose() methods to <dialog>, connects the pointer
    events handling to a new dialog light dismiss method, and adds a
    basic set of tests. None of the actual functionality is here yet,
    this is just a shell. Subsequent CLs will flesh out the behavior.
    
    See spec PR for details:
      whatwg/html#10737
    
    Here's the chromestatus:
      https://chromestatus.com/feature/5097714453577728
    
    Bug: 376516550
    Change-Id: I3727ca21476a2a3340fd18597970395d64ef7176
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5985491
    Commit-Queue: Mason Freed <[email protected]>
    Reviewed-by: David Baron <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#1378633}
    mfreed7 authored and chromium-wpt-export-bot committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f271812 View commit details
    Browse the repository at this point in the history