Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: String extension codestyle change #851

Conversation

JeneaVranceanu
Copy link
Collaborator

@JeneaVranceanu JeneaVranceanu commented Mar 31, 2024

Summary of Changes

"Fixes" codestyle:

  • fullNSRange is no longer a computed variable but a function fullNSRange();
  • Changed the order of public, internal and default visibility functions in String+Extension.swift;
  • Removed asciiValue extension from String and Character types as it's not used and is not public.

Test Data or Screenshots

None

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu JeneaVranceanu added ready for review issue is resolved, a final review is needed before closing refactoring labels Apr 1, 2024
@JeneaVranceanu JeneaVranceanu merged commit 905e464 into web3swift-team:develop-4.0 Sep 18, 2024
1 check passed
@JeneaVranceanu JeneaVranceanu deleted the chore/string-extenion-codestyle-change branch September 18, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 ready for review issue is resolved, a final review is needed before closing refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants