Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add catalog-server and catalog-api packages #1323
Add catalog-server and catalog-api packages #1323
Changes from 7 commits
131867c
1d737d2
0322381
679b03e
416c0da
aa2e8c0
7c839b6
f9d3ba1
1c7ecf3
71181d9
4485ed1
3056de3
8d4b9df
80d2758
c88df50
7b4d678
5ccb70b
65878b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens when we notice that a distTag is moved to a new version? we write to both PackageVersions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This is what I'm working on right now. We only know the dist-tags when we import a package, and then because we denormalize we have to update all package versions and all custom elements that had a dist-tag change. Since we store the dist-tags, we can calculate if/when we need to do that.