Add Import Package page to catalog #1421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL below and will update on each commit. = https://pr1421---site-khswqo4xea-wl.a.run.app/
|
aomarks
requested changes
Jan 18, 2023
| export class WCOCatalogImportPage extends WCOPage { | ||
| private _importTask = new Task(this, { | ||
| task: async ([packageName]: [packageName: string | undefined]) => { | ||
| console.log('_importTask', packageName); |
| packageName, | ||
| }), | ||
| }); | ||
| const result = await response.json(); |
There was a problem hiding this comment.
Think we need to check the response code before parsing the json? Since fetch doesn't throw on HTTP errors.
There was a problem hiding this comment.
I think we can let .json() throw and add a error template.
| unknown | ||
| > | ||
| ) => { | ||
| console.log('context.request.body', context.request.body); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
/catalog/importGET endpoint for the import page and POST endpoint for the import operation.The page is extremely basic and just dumps the JSON output of the response to the screen.
Did a few cleanups on route file organization to make things simpler too.