Add some notes for flags to README #300
Conversation
README.md
Outdated
| @@ -56,6 +56,11 @@ To get started with WebNN on Intel AI PCs you will need: | |||
| #### Running WebNN on CPU or GPU | |||
| 1. Launch Chrome Canary or Edge Canary | |||
|
|
|||
| * **Notes**: | |||
|
|
|||
| 1. Running WebNN on Qualcomm GPUs is disabled by default. You can use the `--disable_webnn_for_gpu=0` flag to bypass. However, the functionality is not guaranteed. | |||
There was a problem hiding this comment.
I think it's better for Qualcomm to add such notes, not from Intel. @mingmingtasd We don't know if Qualcomm guarantees the functionality or not at all.
There was a problem hiding this comment.
I remember we want a README that includes descriptions of all the flags. I can remove the note for
disable_webnn_for_gpu for Qualcomm, then that means if people run on Qualcomm and see GPU blocked issue, it's not our responsibility to tell them: you should use --disable_webnn_for_gpu=0 flag. WDYT?
There was a problem hiding this comment.
But agree to remove the sentence "However, the functionality is not guaranteed." for Qualcomm, we should not judge other vendors
There was a problem hiding this comment.
Done by the new commit, PTAL, thanks! @ibelem
| @@ -84,7 +89,8 @@ At present, the [image classification](https://webmachinelearning.github.io/webn | |||
|
|
|||
| * **Notes**: | |||
|
|
|||
| Running WebNN on NPU requires a higher version of DirectML.dll than the one in the Windows system. Using the `--use-redist-dml` flag will allow Google Chrome Canary to load the downloaded DirectML.dll with a sufficiently high version. | |||
| 1. Running WebNN on NPU requires a higher version of DirectML.dll than the one in the Windows system. Using the `--use-redist-dml` flag will allow Google Chrome Canary to load the downloaded DirectML.dll with a sufficiently high version. | |||
| 2. Since the NPU drivers may be blocked by default if they are not the latest [Intel® Core™ Ultra NPU Driver on Windows](https://www.intel.com/content/www/us/en/download/794734/intel-npu-driver-windows.html), you can use the `--disable_webnn_for_npu=0` flag to bypass. However, the functionality is not guaranteed. | |||
There was a problem hiding this comment.
Do we really need However, the functionality is not guaranteed.? This is known to users by default before officially shipping WebNN.
There was a problem hiding this comment.
I just intend to be responsible for these new added notes, to notice that if you follow these notes, you may meet functionality issues.
Agree that the However, the functionality is not guaranteed is negative, I am OK to remove them if you think that's really not necessary.
|
@Honry @huningxin PTAL |
Add some notes for
--disable_webnn_for_gpu,--disable_webnn_for_npuand--disable_dml_meta_commands_for_gpuin README.PTAL, thanks!
@ibelem @Honry @huningxin