Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing root property to vitest #677

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Add missing root property to vitest #677

merged 2 commits into from
Jun 15, 2024

Conversation

nebez
Copy link
Contributor

@nebez nebez commented Jun 13, 2024

This adds support for the Vitest root config. Without it, valid vitest.config.ts and vitest.workspace.ts files were being improperly parsed.

Existing fixtures and tests are still passing. Added a new test to prove root does indeed change the relative path in which files are include (incl. global and setup files).

Copy link

netlify bot commented Jun 13, 2024

‼️ Deploy request for knip rejected.

Name Link
🔨 Latest commit 17754e3

@webpro
Copy link
Collaborator

webpro commented Jun 15, 2024

Wonderful PR, thanks @nebez! Well done, happy to merge this in.

@webpro webpro merged commit 6797bf8 into webpro-nl:main Jun 15, 2024
11 checks passed
@webpro
Copy link
Collaborator

webpro commented Jun 16, 2024

🚀 This pull request is included in v5.20.0. See Release 5.20.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants