Don't log user initiated abort as err #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some shutdown scenarios were we do sctp user initiated abort this generates Error in our log and we cannot turn it off.
Since the abort is intentional this PR, suggest to change this error message to debug instead.
Tested with our server and I verified that the change caused this line:
2024-04-28T03:06:35.556480Z ERROR sctp_proto::association: handle_inbound got err: abort chunk, with following errors: (User Initiated Abort)
to:
2024-04-28T03:48:57.762789Z DEBUG sctp_proto::association: User initiated abort received