-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respond with ParamOutgoingResetRequest #6
Conversation
This is marked as Draft, since I think we need to check spec here. It might be the close calls shouldn't be automatic in sctp-proto, but a stream from outside @k0nserv is good with the spec detective work. |
The spec seems pretty clear: respond with an OutgoingResetRequest when one is received to confirm the closure. However, I'm not sure Pion implemented it like this in the end, there's a lot of relevant discussion in pion/sctp#238 |
I tried to replicate pion's fix in webrtc-rs/webrtc which seems to work |
So maybe this solve is more correct. If only we could make it close straight away and not wait for the next RTO. |
We are not waiting for any RTO. We are sending something straight away, but it seems this gets rejected and then we manage to send the close confirm on retransmit. |
5675578
to
ac26f74
Compare
I think this might be ready. The problem was that the response |
Hi @rainliu what do you think about this fix? |
This is a fix for the issue reported in algesten/str0m#286