-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.9.10.27 #241
base: 3.9.10.27
Are you sure you want to change the base?
3.9.10.27 #241
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 595187a in 15 seconds
More details
- Looked at
25
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_5x4L8pSGHqsjkGoO
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -380,8 +380,8 @@ class PuppetXp extends PUPPET.Puppet { | |||
} | |||
|
|||
// revert talkerId and toId according to isMyMsg | |||
if (args[5] === 1) { | |||
toId = talkerId | |||
if (!talkerId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition change from args[5] === 1
to !talkerId
might alter the logic significantly. Ensure this change aligns with the intended behavior.
Summary:
This pull request updates the
PuppetXp
class insrc/puppet-xp.ts
to improve message sender and receiver ID handling and removes an empty conditional block.Key points:
src/puppet-xp.ts
PuppetXp
onHookRecvMsg
toId
tothis.selfInfo.id
whentalkerId
is not present.args[5] === 1
.PUPPET.types.Message.Transfer
.Generated with ❤️ by ellipsis.dev