Skip to content

Commit

Permalink
Remove linting from Makefile due to golangci-lint issues
Browse files Browse the repository at this point in the history
Signed-off-by: Paul Balogh <[email protected]>
  • Loading branch information
javaducky committed Jan 20, 2024
1 parent 41cb9eb commit 1ee3888
Showing 1 changed file with 7 additions and 22 deletions.
29 changes: 7 additions & 22 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ DOCKER_TAG := $(BUILD_VERSION)
LINKER_FLAGS := "-X $(PROJECT_MODULE)/env.Version=$(BUILD_VERSION) -X $(PROJECT_MODULE)/env.Revision=$(BUILD_REVISION)"


all: imports fmt lint vet build
all: imports fmt vet build

## help: Prints a list of available build targets.
help:
Expand All @@ -36,7 +36,7 @@ help:
echo "Targets run by default are: `sed -n 's/^all: //p' ./Makefile | sed -e 's/ /, /g' | sed -e 's/\(.*\), /\1, and /'`"

## clean-all: Scrub all build artifacts and vendored code.
clean-all: clean clean-vendor
clean-all: clean

## clean: Remove all build artifacts and generated files.
clean: clean-artifacts
Expand All @@ -47,10 +47,6 @@ clean: clean-artifacts
clean-artifacts:
rm -Rf artifacts/

## clean-vendor: Remove vendored code.
clean-vendor:
find $(CURDIR)/vendor -type d -print0 2>/dev/null | xargs -0 rm -Rf

## deps: Verifies and cleans up module dependencies.
deps:
echo "Tidying modules..."
Expand All @@ -70,11 +66,6 @@ fmt:
echo "Formatting code..."
go fmt ./...

## lint: Reports any stylistic mistakes on the codebase.
lint:
echo "Linting code..."
golangci-lint run

## vet: Searches for any suspicious constructs within the codebase.
vet:
echo "Vetting code..."
Expand All @@ -84,11 +75,10 @@ vet:
setup:
echo "Installing tools..."
go install golang.org/x/tools/cmd/goimports@latest
go get -u golang.org/x/lint/golint


## build: Build the application.
build: deps imports fmt lint vet build-only
build: deps imports fmt vet build-only

## build-only: Build without prerequisite steps
build-only:
Expand All @@ -99,7 +89,7 @@ build-only:
-o "bin/$(PROJECT_NAME)" .

## build-all: Builds all architectures of the application.
build-all: deps imports fmt lint vet
build-all: deps imports fmt vet
mkdir -v -p $(CURDIR)/artifacts
gox -verbose \
-os "$(BUILD_OS)" -arch "$(BUILD_ARCH)" \
Expand All @@ -117,13 +107,8 @@ build-docker:
release-docker: build-docker
docker push $(DOCKER_IMAGE):$(DOCKER_TAG)

## vendor: Pull dependent code into the codebase for direct inclusion.
vendor: deps
echo "Vendoring dependencies..."
go mod vendor


.PHONY: build build-all \
clean clean-all clean-artifacts clean-vendor \
deps fmt help imports lint \
setup test vendor vet
clean clean-all clean-artifacts \
deps fmt help imports \
setup test vet

0 comments on commit 1ee3888

Please sign in to comment.